Add go routine to create partition tables periodically #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Nov 25, 2020
| halfDayLater := when.Add(12 * time.Hour) | ||
| for _, table := range []Table{auditLogEventsTable, requestInfoTable} { | ||
| partitionExists, err := c.checkPartitionTableExists(bgCtx, table.Name, halfDayLater) | ||
| log.Printf("Error while checking if partition for %s exists %s", table.Name, err) |
There was a problem hiding this comment.
For logging since is is part of k8s start using klog? which provides more k8s friendly logging?
krisis
force-pushed
the
create-partition
branch
from
a3f34b0 to
6271dfe
Compare
harshavardhana
approved these changes
Nov 26, 2020
donatello
approved these changes
Nov 27, 2020
jmontleon
added a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
When using psql, errors in applying the sql generated from the dump do not reach bash without adding additional options. psql only generates a non-zero exit code when something fatal happens, like being unable to connect to the database host. So, all ansible sees is exit code 0 from psql and continues on, as if everything is great. I did some reading up on postgres modules for ansible and we do not need to shell out to do this, so I have implemented it with modules. Since handling the actual migration with the ansible modules I have not encountered a failure. Continuing to run upgrades to test ... --------- Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.